Bug 124874

Summary: Remote Layer Tree: Support cloning layers
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
simon.fraser: review+
fix comments except cast simon.fraser: review+

Tim Horton
Reported 2013-11-25 17:23:20 PST
For reflections, etc. <rdar://problem/15349468>
Attachments
patch (7.76 KB, patch)
2013-11-25 17:30 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
fix comments except cast (12.09 KB, patch)
2013-12-02 14:25 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-11-25 17:30:32 PST
Created attachment 217852 [details] patch
Simon Fraser (smfr)
Comment 2 2013-12-02 11:24:37 PST
Comment on attachment 217852 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=217852&action=review Does the right cleanup happen when a mask layer is removed? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:102 > + clone->m_properties.notePropertiesChanged(static_cast<RemoteLayerTreeTransaction::LayerChange>(m_properties.everChangedProperties & ~RemoteLayerTreeTransaction::BackingStoreChanged)); Ugly cast :( > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:276 > + m_maskLayer = toPlatformCALayerRemote(layer); Can we call the field m_maskLayerID please? (Same with other LayerID fields).
Tim Horton
Comment 3 2013-12-02 14:25:07 PST
Created attachment 218215 [details] fix comments except cast
Tim Horton
Comment 4 2013-12-02 14:40:00 PST
http://trac.webkit.org/changeset/159967
Note You need to log in before you can comment on or make changes to this bug.