| Summary: | Remote Layer Tree: Support cloning layers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, sam, simon.fraser | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2013-11-25 17:23:20 PST
Created attachment 217852 [details]
patch
Comment on attachment 217852 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=217852&action=review Does the right cleanup happen when a mask layer is removed? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:102 > + clone->m_properties.notePropertiesChanged(static_cast<RemoteLayerTreeTransaction::LayerChange>(m_properties.everChangedProperties & ~RemoteLayerTreeTransaction::BackingStoreChanged)); Ugly cast :( > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:276 > + m_maskLayer = toPlatformCALayerRemote(layer); Can we call the field m_maskLayerID please? (Same with other LayerID fields). Created attachment 218215 [details]
fix comments except cast
|