Bug 124871

Summary:

[WebGL] Implement OES texture float linear

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebGL

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, eflews.bot, esprehn+autocc, gtk-ews, gyuyoung.kim, kondapallykalyan, ltilve+ews, nayankk, noam, rakuco, rego+ews, roger_fong, sam, webkit-bug-importer, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	bfulgham: review+

Dean Jackson

Reported 2013-11-25 16:45:09 PST

This demo was passed around last week: http://www.cake23.de/fmx/turing-fluid-particle-projection-feedback.html WebKit gets a warning saying we don't implement OES_texture_float_linear.

Attachments
Patch (42.17 KB, patch) 2013-12-01 21:23 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (42.15 KB, patch) 2013-12-01 21:35 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (65.06 KB, patch) 2013-12-01 21:52 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (65.11 KB, patch) 2013-12-03 10:33 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (75.42 KB, patch) 2013-12-03 10:55 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (75.42 KB, patch) 2013-12-03 11:15 PST, Dean Jackson	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2013-11-25 16:45:51 PST

<rdar://problem/15548220 >

Dean Jackson

Comment 2 2013-11-25 16:49:41 PST

<rdar://problem/15548220> (not sure what is up with the tool that adds this with an extra newline)

Dean Jackson

Comment 3 2013-11-25 16:50:58 PST

I've got the web facing bits done. Just need to make sure we actually use the right code in the implementation.

Dean Jackson

Comment 4 2013-12-01 20:54:48 PST

Renaming this to only be about enabling float linear, and not yet half float linear, which will depend on 110936

Dean Jackson

Comment 5 2013-12-01 21:23:41 PST

Created attachment 218139 [details] Patch

WebKit Commit Bot

Comment 6 2013-12-01 21:26:15 PST

Attachment 218139 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1 Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 7 2013-12-01 21:28:06 PST

Comment on attachment 218139 [details] Patch Attachment 218139 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/41718007

EFL EWS Bot

Comment 8 2013-12-01 21:30:22 PST

Comment on attachment 218139 [details] Patch Attachment 218139 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/40008280

Dean Jackson

Comment 9 2013-12-01 21:35:24 PST

Created attachment 218140 [details] Patch

WebKit Commit Bot

Comment 10 2013-12-01 21:39:36 PST

Attachment 218140 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1 Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 11 2013-12-01 21:41:16 PST

Comment on attachment 218140 [details] Patch Attachment 218140 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/41648016

EFL EWS Bot

Comment 12 2013-12-01 21:42:34 PST

Comment on attachment 218140 [details] Patch Attachment 218140 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/39908274

kov's GTK+ EWS bot

Comment 13 2013-12-01 21:43:16 PST

Comment on attachment 218140 [details] Patch Attachment 218140 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/41648017

Dean Jackson

Comment 14 2013-12-01 21:52:58 PST

Created attachment 218141 [details] Patch

WebKit Commit Bot

Comment 15 2013-12-01 21:54:18 PST

Attachment 218141 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear-expected.txt', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1 Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 16 2013-12-01 21:57:16 PST

Comment on attachment 218141 [details] Patch Attachment 218141 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/41718014

kov's GTK+ EWS bot

Comment 17 2013-12-01 21:58:32 PST

Comment on attachment 218141 [details] Patch Attachment 218141 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/41268018

EFL EWS Bot

Comment 18 2013-12-01 22:02:05 PST

Comment on attachment 218141 [details] Patch Attachment 218141 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/41698012

Dean Jackson

Comment 19 2013-12-03 10:33:59 PST

Created attachment 218306 [details] Patch

EFL EWS Bot

Comment 20 2013-12-03 10:39:57 PST

Comment on attachment 218306 [details] Patch Attachment 218306 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/39358321

Dean Jackson

Comment 21 2013-12-03 10:55:40 PST

Created attachment 218309 [details] Patch

EFL EWS Bot

Comment 22 2013-12-03 11:10:11 PST

Comment on attachment 218309 [details] Patch Attachment 218309 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/42108154

Dean Jackson

Comment 23 2013-12-03 11:15:24 PST

Created attachment 218312 [details] Patch

Brent Fulgham

Comment 24 2013-12-03 11:43:59 PST

Comment on attachment 218312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218312&action=review r=me. > Source/WebCore/html/canvas/WebGLRenderingContext.h:564 > + void checkTextureCompleteness(const char*, bool); I like this name change! > Source/WebCore/html/canvas/WebGLTexture.cpp:369 > + m_isFloatType = m_info[0][0].type == GraphicsContext3D::FLOAT; :-(

Dean Jackson

Comment 25 2013-12-03 12:19:11 PST

Committed r160030: <http://trac.webkit.org/changeset/160030>

Brent Fulgham

Comment 26 2014-01-10 10:45:57 PST

*** Bug 109853 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.