Bug 124863

Summary: mediaControlsUserAgentStyleSheet not defined on Windows
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Trivial CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2013-11-25 15:02:05 PST
I'm not sure where the definition for mediaControlsUserAgentStyleSheet is, but it's causing compile errors with GStreamer on Windows since http://trac.webkit.org/changeset/156546 I assume it's part of CA. This makes it compile, but I have no idea what this code is doing.
Attachments
Patch (1.74 KB, patch)
2013-11-25 15:03 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2013-12-16 20:05 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2013-12-16 20:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-11-25 15:03:47 PST
Created attachment 217836 [details] Patch
Jer Noble
Comment 2 2013-11-26 08:00:19 PST
Comment on attachment 217836 [details] Patch CA is the wrong protector. This should be #if ENABLE(MEDIA_CONTROLS_SCRIPT).
Alex Christensen
Comment 3 2013-12-16 20:05:00 PST
Created attachment 219388 [details] Patch
Alex Christensen
Comment 4 2013-12-16 20:18:32 PST
Are you sure this shouldn't be #if ENABLE(VIDEO_TRACK) ?
Alex Christensen
Comment 5 2013-12-16 20:28:56 PST
Created attachment 219391 [details] Patch
Alex Christensen
Comment 6 2013-12-17 10:31:47 PST
This isn't causing me a problem anymore because I'm only compiling this code with MEDIA_CONTROLS_SCRIPT and VIDEO_TRACK enabled.
Note You need to log in before you can comment on or make changes to this bug.