| Summary: | test-webkit-scripts should show the failing tests and use an appropriate exit code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Berta József <jberta.u-szeged> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ossy, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Berta József
2013-11-25 05:24:20 PST
Created attachment 217795 [details]
The script now indicates the results, and calls sys.exit()
Comment on attachment 217795 [details] The script now indicates the results, and calls sys.exit() View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review > Tools/Scripts/test-webkit-scripts:84 > + print('test-webkiterl') Typo: 'test-webkiterl' -> 'test-webkitperl' Comment on attachment 217795 [details] The script now indicates the results, and calls sys.exit() View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review > Tools/ChangeLog:7 > + Please explain what kind of changes you're making. r- due to the lack of the change log. Created attachment 217809 [details]
I have added description to the changelog. Typo corrected.
Comment on attachment 217809 [details] I have added description to the changelog. Typo corrected. View in context: https://bugs.webkit.org/attachment.cgi?id=217809&action=review > Tools/ChangeLog:3 > + Cumulative indication of success or failure in test-webkit-scripts Please update this line as I've updated the bug title. Created attachment 217873 [details]
The changelog is updated.
Comment on attachment 217873 [details] The changelog is updated. It was already r+ -ed, only the changelog was missing. The fixed patch landed in https://trac.webkit.org/changeset/159868 |