Summary: | ImageBuffer::create should return a unique_ptr instead of OwnPtr. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||
Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, darin, dino, d-r, eflews.bot, eric.carlson, esprehn+autocc, fmalita, glenn, gtk-ews, gyuyoung.kim, jer.noble, kondapallykalyan, luiz, macpherson, menard, noam, pdr, philn, rego+ews, roger_fong, schenney, sergio, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 124325 | ||||||||||||
Attachments: |
|
Description
Brian Burg
2013-11-24 18:12:18 PST
Created attachment 217772 [details]
v1
Comment on attachment 217772 [details] v1 Attachment 217772 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/35168398 Comment on attachment 217772 [details] v1 Attachment 217772 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/35318405 Created attachment 217773 [details]
v2
Comment on attachment 217773 [details] v2 Attachment 217773 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/36148162 Comment on attachment 217773 [details] v2 Attachment 217773 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/35188428 Created attachment 217775 [details]
v3
Comment on attachment 217775 [details] v3 Attachment 217775 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/35358389 Comment on attachment 217775 [details] v3 Attachment 217775 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/35318411 Comment on attachment 217775 [details] v3 Attachment 217775 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/35328394 Created attachment 217805 [details]
v3
Comment on attachment 217805 [details] v3 Attachment 217805 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/36468068 Comment on attachment 217805 [details] v3 View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review > Source/WebCore/platform/graphics/ImageBuffer.h:84 > + std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success)); It might be better to use std::make_unique here: auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success); (In reply to comment #13) > (From update of attachment 217805 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review > > > Source/WebCore/platform/graphics/ImageBuffer.h:84 > > + std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success)); > > It might be better to use std::make_unique here: > auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success); Ah, true. Thanks for pointing it out. Not sure why WK2 EFL bot is hitting an ICE, or why the preflight test is crashy. :-/ (In reply to comment #15) > Not sure why WK2 EFL bot is hitting an ICE, or why the preflight test is crashy. :-/ By the looks of the error message, looks like it hit an OOM condition, which in general isn't related to the patch being tested. Just to make your life harder :) Comment on attachment 217805 [details]
v3
r=me.
EFL EWS has been ICE'ing randomly for ages, nothing to do with your patch.
Comment on attachment 217805 [details] v3 Clearing flags on attachment: 217805 Committed r159791: <http://trac.webkit.org/changeset/159791> All reviewed patches have been landed. Closing bug. |