Bug 12482

Summary: Add small-caps to list of traits to ignore as it can be synthesized
Product: WebKit Reporter: Nicholas Shanks <nickshanks>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, mitz, vitor.roriz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch darin: review-

Nicholas Shanks
Reported 2007-01-30 10:51:24 PST
The fix for bug #6146 forgot to handle small-caps, which is also synthesized. Although currently the small-caps trait is not requested (since it is always synthesized), I plan on fixing that. This code ought to be ready to handle requests that include the small-caps trait.
Attachments
patch (1.74 KB, patch)
2007-01-30 10:52 PST, Nicholas Shanks 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nicholas Shanks
Comment 1 2007-01-30 10:52:18 PST
Created attachment 12800 [details] patch
Darin Adler
Comment 2 2007-01-30 10:53:29 PST
Comment on attachment 12800 [details] patch Need a test case and a ChangeLog entry.
Nicholas Shanks
Comment 3 2007-01-30 18:52:33 PST
What sort of test case do you suggest? Since font-variant: small-caps doesn't request a font with the NSFontSmallCapsMask trait presently, I don't think it can be tested.
Ahmad Saleem
Comment 4 2024-04-19 12:24:38 PDT
This patch was modifying 'WebFontCache.mm', which was deleted by this commit: https://github.com/WebKit/WebKit/commit/cf78b9f051b13cd4ddcfb8bfc570174a6e2faafd We don't have test case to understand to confirm whether the bug exist or not. @Vitor - is this applicable any more?
Note You need to log in before you can comment on or make changes to this bug.