Bug 12482

Summary: Add small-caps to list of traits to ignore as it can be synthesized
Product: WebKit Reporter: Nicholas Shanks <nickshanks>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: mitz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch darin: review-

Description Nicholas Shanks 2007-01-30 10:51:24 PST
The fix for bug #6146 forgot to handle small-caps, which is also synthesized. Although currently the small-caps trait is not requested (since it is always synthesized), I plan on fixing that. This code ought to be ready to handle requests that include the small-caps trait.
Comment 1 Nicholas Shanks 2007-01-30 10:52:18 PST
Created attachment 12800 [details]
patch
Comment 2 Darin Adler 2007-01-30 10:53:29 PST
Comment on attachment 12800 [details]
patch

Need a test case and a ChangeLog entry.
Comment 3 Nicholas Shanks 2007-01-30 18:52:33 PST
What sort of test case do you suggest? Since font-variant: small-caps doesn't request a font with the NSFontSmallCapsMask trait presently, I don't think it can be tested.