Bug 124793

Summary: CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116888    
Attachments:
Description Flags
the patch
mhahnenberg: review+
patch for landing none

Description Filip Pizlo 2013-11-22 15:15:57 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-22 15:19:56 PST 
Created attachment 217719 [details]
the patch
Comment 2 Mark Hahnenberg 2013-11-22 15:31:11 PST 
Comment on attachment 217719 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217719&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGraph.cpp:709
> +    unsigned count = m_profiledBlock->m_numCalleeRegisters;

JIT::frameRegisterCountFor(m_profiledBlock)

> Source/JavaScriptCore/dfg/DFGGraph.cpp:713
> +        unsigned requiredCount = VirtualRegister(inlineCallFrame->stackOffset).toLocal() + 1 + codeBlock->m_numCalleeRegisters;

JIT::frameRegisterCountFor(codeBlock)

> Source/JavaScriptCore/dfg/DFGGraph.cpp:715
> +        if (requiredCount > count)
> +            count = requiredCount;

max?
Comment 3 Filip Pizlo 2013-11-22 16:15:17 PST 
Created attachment 217724 [details]
patch for landing
Comment 4 Filip Pizlo 2013-11-22 16:35:48 PST 
Landed in http://trac.webkit.org/changeset/159721