Bug 124749

Summary: JSC: Removed unused opcodes from offline assembler
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mhahnenberg: review+

Michael Saboff
Reported 2013-11-21 16:34:14 PST
The opcodes peek and pokeq are not currently used by the LLInt and therefore are redundant. The desire to remove these at this time is due to a limitation in size of regular expressions in ruby. For the patch https://bugs.webkit.org/show_bug.cgi?id=124721 - "ARM64: Implement push/pop equivalents in LLInt" I'd like to add two new opcodes. By removing these two opcodes, we can add the opcodes in that patch.
Attachments
Patch (2.25 KB, patch)
2013-11-21 16:41 PST, Michael Saboff 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-21 16:41:24 PST
Created attachment 217627 [details] Patch
Mark Hahnenberg
Comment 2 2013-11-21 16:42:34 PST
Comment on attachment 217627 [details] Patch r=me
Michael Saboff
Comment 3 2013-11-21 16:43:49 PST
Committed r159654: <http://trac.webkit.org/changeset/159654>
Note You need to log in before you can comment on or make changes to this bug.