Bug 124716

Summary: [MIPS] Build fails since r159545.
Product: WebKit Reporter: Balazs Kilvady <kilvadyb>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, fu, gergely, ggaren, jbriance, msaboff, palfia
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
fixed patch. none

Balazs Kilvady
Reported 2013-11-21 07:20:22 PST
The "memfence" opcode is missing from LLINT and the following implementations are missing from MacroAssemblerMIPS.h since r159545: - void memoryFence() - void store8(RegisterID, const void*)
Attachments
proposed patch. (2.61 KB, patch)
2013-11-21 09:30 PST, Balazs Kilvady 		no flags
DetailsFormatted DiffDiff
fixed patch. (2.60 KB, patch)
2013-11-21 09:39 PST, Balazs Kilvady 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kilvady
Comment 1 2013-11-21 09:30:32 PST
Created attachment 217576 [details] proposed patch.
Julien Brianceau
Comment 2 2013-11-21 09:34:04 PST
Comment on attachment 217576 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=217576&action=review > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:998 > + m_assembler.sb(immTempRegister, addrTempRegister, 0); Why src RegisterID parameter is not used here?
Balazs Kilvady
Comment 3 2013-11-21 09:39:10 PST
Created attachment 217577 [details] fixed patch.
WebKit Commit Bot
Comment 4 2013-11-21 10:29:46 PST
Comment on attachment 217577 [details] fixed patch. Clearing flags on attachment: 217577 Committed r159635: <http://trac.webkit.org/changeset/159635>
WebKit Commit Bot
Comment 5 2013-11-21 10:29:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.