Bug 124716

Summary:

[MIPS] Build fails since r159545.

Product:

WebKit

Reporter:

Balazs Kilvady <kilvadyb>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, fu, gergely, ggaren, jbriance, msaboff, palfia

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none
fixed patch.	none

Description Balazs Kilvady 2013-11-21 07:20:22 PST

The "memfence" opcode is missing from LLINT and the following implementations are missing from MacroAssemblerMIPS.h since r159545:
- void memoryFence()
- void store8(RegisterID, const void*)

Comment 1 Balazs Kilvady 2013-11-21 09:30:32 PST

Created attachment 217576 [details]
proposed patch.

Comment 2 Julien Brianceau 2013-11-21 09:34:04 PST

Comment on attachment 217576 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=217576&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:998
> +        m_assembler.sb(immTempRegister, addrTempRegister, 0);

Why src RegisterID parameter is not used here?

Comment 3 Balazs Kilvady 2013-11-21 09:39:10 PST

Created attachment 217577 [details]
fixed patch.

Comment 4 WebKit Commit Bot 2013-11-21 10:29:46 PST

Comment on attachment 217577 [details]
fixed patch.

Clearing flags on attachment: 217577

Committed r159635: <http://trac.webkit.org/changeset/159635>

Comment 5 WebKit Commit Bot 2013-11-21 10:29:48 PST

All reviewed patches have been landed.  Closing bug.