Bug 124707 – Generate toHTMLMarquee|OListElement() to cleanup static_cast<>

• Component: New Bugs
• Status: RESOLVED FIXED

[Gyuyoung Kim]

As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement(). Besides this patch cleans up remaining static_cast<> usage.

[Gyuyoung Kim]

Created attachment 217542 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 217542 [details]
Patch

There is no regression on layout test when I run layout test locally.

[Gyuyoung Kim]

CC'ing Darin.

[Darin Adler]

Comment on attachment 217542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217542&action=review

> Source/WebCore/rendering/RenderMarquee.cpp:78
>      if (element && element->hasTagName(marqueeTag)) {
> -        HTMLMarqueeElement* marqueeElement = static_cast<HTMLMarqueeElement*>(element);
> -        result = std::max(result, marqueeElement->minimumDelay());
> +        result = std::max(result, toHTMLMarqueeElement(element)->minimumDelay());
>      }

WebKit coding style says we remove the braces when an if statement becomes a single line like this.

[Gyuyoung Kim]

Created attachment 217742 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 217742 [details]
Patch

Clearing flags on attachment: 217742

Committed r159733: <http://trac.webkit.org/changeset/159733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.