Bug 12470

Summary:

svn-create-patch creates duplicate patches for files within an added/modified directory

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch v1	mrowe: review+

Description David Kilzer (:ddkilzer) 2007-01-29 22:51:24 PST

While creating the latest patch for Bug 11882, I noticed that I kept getting duplicate copies of all of the new webarchive layout tests and their results in the patch.  The problem was that svn-create-patch saw "LayoutTests/webarchive" as a modified "file", and ran a diff on it.

The correct solution (for now) is to ignore modified directories when creating a patch.

I have a patch to fix this.

Comment 1 David Kilzer (:ddkilzer) 2007-01-29 22:53:49 PST

Created attachment 12777 [details]
Patch v1

Proposed fix.

Comment 2 Mark Rowe (bdash) 2007-01-30 04:49:07 PST

Comment on attachment 12777 [details]
Patch v1

r=me

Comment 3 David Kilzer (:ddkilzer) 2007-01-30 06:42:07 PST

Committed revision 19256.