Bug 12470 - svn-create-patch creates duplicate patches for files within an added/modified directory
Summary: svn-create-patch creates duplicate patches for files within an added/modified...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-01-29 22:51 PST by David Kilzer (:ddkilzer)
Modified: 2007-01-30 06:42 PST (History)
0 users

See Also:

Patch v1 (1.17 KB, patch)
2007-01-29 22:53 PST, David Kilzer (:ddkilzer)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2007-01-29 22:51:24 PST
While creating the latest patch for Bug 11882, I noticed that I kept getting duplicate copies of all of the new webarchive layout tests and their results in the patch.  The problem was that svn-create-patch saw "LayoutTests/webarchive" as a modified "file", and ran a diff on it.

The correct solution (for now) is to ignore modified directories when creating a patch.

I have a patch to fix this.
Comment 1 David Kilzer (:ddkilzer) 2007-01-29 22:53:49 PST
Created attachment 12777 [details]
Patch v1

Proposed fix.
Comment 2 Mark Rowe (bdash) 2007-01-30 04:49:07 PST
Comment on attachment 12777 [details]
Patch v1

Comment 3 David Kilzer (:ddkilzer) 2007-01-30 06:42:07 PST
Committed revision 19256.