Bug 124676 – webkitdirs::checkForArgumentAndRemoveFromArrayRef() removes wrong element

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Nick Diego Yamane (diegoyam)]

webkitdirs::checkForArgumentAndRemoveFromArrayRef remove wrong elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be {b, a}, when it should be {b, c}.

[Nick Diego Yamane (diegoyam)]

Created attachment 217480 [details]
Patch

[Daniel Bates]

Comment on attachment 217480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217480&action=review

This patch look a reasonable to me. Ideally, we could reduce some duplication of code in the unit test. For now, it's OK.

> Tools/ChangeLog:3
> +        Fix a bug in webkitdirs::checkForArgumentAndRemoveFromArrayRef

This title is ambiguous. I updated the Bugzilla bug title to be: webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element

Feel free to use this bug title or come up with a more descriptive one.

[Nick Diego Yamane (diegoyam)]

Created attachment 217567 [details]
Patch for landing

[Nick Diego Yamane (diegoyam)]

Created attachment 217570 [details]
Patch for landing 2

[Nick Diego Yamane (diegoyam)]

Created attachment 217575 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 217575 [details]
Patch

Clearing flags on attachment: 217575

Committed r159668: <http://trac.webkit.org/changeset/159668>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.