Bug 124670
| Summary: | [Win] GraphicsSurfaceWin.cpp is missing after r156795 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Arunprasad Rajkumar <arurajku> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Major | CC: | ararunprasad, bfulgham, kling, zeno |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Other | ||
| Bug Depends on: | 122228 | ||
| Bug Blocks: | |||
Arunprasad Rajkumar
GraphicsSurfaceWin.cpp is available at http://trac.webkit.org/log/trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp?rev=156794 but missing after http://trac.webkit.org/changeset/156795. But SVN log doesn't show that file is removed.
Something weird is happening!!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228.
SVN/Trac history shows this, so I don't see anything wrong.
Arunprasad Rajkumar
(In reply to comment #1)
> This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228.
>
> SVN/Trac history shows this, so I don't see anything wrong.
I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so?
Brent Fulgham
(In reply to comment #2)
> (In reply to comment #1)
> > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228.
> >
> > SVN/Trac history shows this, so I don't see anything wrong.
>
> I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so?
The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time.
Arunprasad Rajkumar
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228.
> > >
> > > SVN/Trac history shows this, so I don't see anything wrong.
> >
> > I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so?
>
> The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time.
So how the WebGL works in WinCairo without a GraphicsSurface implementation? Is it uses something from CoreGraphics/CoreAnimation?
Arunprasad Rajkumar
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228.
> > > >
> > > > SVN/Trac history shows this, so I don't see anything wrong.
> > >
> > > I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so?
> >
> > The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time.
>
> So how the WebGL works in WinCairo without a GraphicsSurface implementation? Is it uses something from CoreGraphics/CoreAnimation?
I meant WK1-WinCairo :)