Bug 124638

Summary: [Shapes] Caching loop iteration number
Product: WebKit Reporter: Przemyslaw Szymanski <p.szymanski3>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, joepeck, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Loop iteration cache
none
Loop iteration cache none

Przemyslaw Szymanski
Reported 2013-11-19 22:47:01 PST
We can cache loop iteration number in firstIncludedIntervalY method. We can't be sure that every compiler do this for us, and it does not cause any overhead.
Attachments
Loop iteration cache (1.56 KB, patch)
2013-11-19 22:50 PST, Przemyslaw Szymanski 		no flags
DetailsFormatted DiffDiff
Loop iteration cache (1.56 KB, patch)
2013-11-19 22:54 PST, Przemyslaw Szymanski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Przemyslaw Szymanski
Comment 1 2013-11-19 22:50:28 PST
Created attachment 217388 [details] Loop iteration cache
Przemyslaw Szymanski
Comment 2 2013-11-19 22:54:39 PST
Created attachment 217389 [details] Loop iteration cache changelog update
Tim Horton
Comment 3 2013-11-20 00:50:42 PST
Comment on attachment 217389 [details] Loop iteration cache View in context: https://bugs.webkit.org/attachment.cgi?id=217389&action=review > Source/WebCore/ChangeLog:11 > + No functionality is changed in this patch. > + > + No new tests. Covered by existing ones. No tests, no functionality change, no performance numbers, no indication that this is a bottleneck or at all interesting to optimize, and no mention of which compiler doesn't do this hoisting (though, just the same, I have no idea which of them do...). Have you seen this show up in a profiler?
Joseph Pecoraro
Comment 4 2015-11-12 21:02:59 PST
Comment on attachment 217389 [details] Loop iteration cache Clearing review flags. This patch is stale as this code was deleted in bug 130740 so duping this to that and closing.
Joseph Pecoraro
Comment 5 2015-11-12 21:03:12 PST
*** This bug has been marked as a duplicate of bug 130740 ***
Note You need to log in before you can comment on or make changes to this bug.