Bug 124635

Summary: Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch v1 with code. thorton: review+

Description Brady Eidson 2013-11-19 22:18:53 PST
Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2

-getOrEstablishIDBDatabaseMetadata should not have to take a database name parameter because the server connection should already know what database name it represents.
-Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess in WK2
Comment 1 Brady Eidson 2013-11-19 22:21:07 PST
Created attachment 217383 [details]
Patch v1
Comment 2 Sam Weinig 2013-11-19 22:22:12 PST
You forgot the code I think.
Comment 3 Brady Eidson 2013-11-19 22:25:10 PST
(In reply to comment #2)
> You forgot the code I think.

One of these days, git and I will get along.
Comment 4 Brady Eidson 2013-11-19 22:25:31 PST
Created attachment 217384 [details]
Patch v1 with code.
Comment 5 Tim Horton 2013-11-19 23:17:25 PST
Comment on attachment 217384 [details]
Patch v1 with code.

View in context: https://bugs.webkit.org/attachment.cgi?id=217384&action=review

> Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h:-63
> -    virtual void open(const String& name, uint64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBDatabaseCallbacks>, const SecurityOrigin& openingOrigin, const SecurityOrigin& mainFrameOrigin) = 0;

what's with the deconstification? (will probably be explained later in the patch). Weren't we bitten by mutable securityorigins in the past?
Comment 6 Brady Eidson 2013-11-20 07:57:59 PST
http://trac.webkit.org/changeset/159563