Bug 124612

Summary: REGRESSION(158384) ARMv7 pointer checks too restrictive for native calls to traditional ARM code
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2013-11-19 15:19:15 PST
The DFG JIT calls out to math library functions like sin(). Those functions might be implemented as traditional ARM functions and therefore fail the ASSERT(reinterpret_cast<intptr_t>(ptr) & 1) test in ASSERT_VALID_CODE_POINTER().
Attachments
Patch (3.23 KB, patch)
2013-11-19 16:04 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-19 15:47:51 PST
There are other checks like ASSERT(reinterpret_cast<intptr_t>(to) & 1) in ARMv7Assembler::linkCall().
Michael Saboff
Comment 2 2013-11-19 16:04:34 PST
Created attachment 217349 [details] Patch
Geoffrey Garen
Comment 3 2013-11-19 16:15:47 PST
Comment on attachment 217349 [details] Patch r=me
Mark Lam
Comment 4 2013-11-19 16:20:00 PST
Comment on attachment 217349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review > Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43 > +// decorated and undectorated null. Should fix the pre-existing typo: "undectorated" ==> "undecorated".
Michael Saboff
Comment 5 2013-11-19 16:29:11 PST
(In reply to comment #4) > (From update of attachment 217349 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43 > > +// decorated and undectorated null. > > Should fix the pre-existing typo: "undectorated" ==> "undecorated". I made this change.
Michael Saboff
Comment 6 2013-11-19 16:32:43 PST
Committed r159532: <http://trac.webkit.org/changeset/159532>
Note You need to log in before you can comment on or make changes to this bug.