Bug 124563

Summary: Removal of redundant function call in Editor::insertTextWithoutSendingTextEvent
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebCore Misc.Assignee: Seokju Kwon <seokju>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Seokju Kwon
Reported 2013-11-18 22:21:53 PST
'text' can never be empty as it's already been checked.
Attachments
Patch (1.46 KB, patch)
2013-11-18 22:24 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-11-18 22:24:25 PST
Created attachment 217273 [details] Patch
Brent Fulgham
Comment 2 2013-11-19 16:58:43 PST
(In reply to comment #0) > 'text' can never be empty as it's already been checked. Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent?
Seokju Kwon
Comment 3 2013-11-19 17:04:56 PST
(In reply to comment #2) > (In reply to comment #0) > > 'text' can never be empty as it's already been checked. > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 )
Brent Fulgham
Comment 4 2013-11-19 20:52:28 PST
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #0) > > > 'text' can never be empty as it's already been checked. > > > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? > > > It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). > (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 ) Got it. I had to look outside the patch to see that. r=me.
WebKit Commit Bot
Comment 5 2013-11-19 21:16:41 PST
Comment on attachment 217273 [details] Patch Clearing flags on attachment: 217273 Committed r159544: <http://trac.webkit.org/changeset/159544>
WebKit Commit Bot
Comment 6 2013-11-19 21:16:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.