Bug 124545 – ARM64 CRASH: Debug builds crash in emitPointerValidation()

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Saboff]

The function emitPointerValidation() uses push()/pop() in debug builds.  These aren't implemented in the ARM64 macro assembler.

[Michael Saboff]

Created attachment 217246 [details]
Patch

[WebKit Commit Bot]

Attachment 217246 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp']" exit_code: 1
Source/JavaScriptCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 217246 [details]
Patch

> Source/JavaScriptCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Changed emitPointerValidation() to use pushToSave() and popToRestore() as
> +	all macro assemblers have an implementation of these functions.
> +

Please fix indentation.

[Michael Saboff]

(In reply to comment #3)
> (From update of attachment 217246 [details])
> > Source/JavaScriptCore/ChangeLog:10
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +	Changed emitPointerValidation() to use pushToSave() and popToRestore() as
> > +	all macro assemblers have an implementation of these functions.
> > +
> 
> Please fix indentation.

Done.  Still setting up a new machine.

[Michael Saboff]

Committed r159469: <http://trac.webkit.org/changeset/159469>