Bug 124540

Summary: APIEntryShims need some love
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 124616    
Bug Blocks: 123195    
Attachments:
Description Flags
Patch fpizlo: review+

Mark Hahnenberg
Reported 2013-11-18 14:53:12 PST
We're missing them in key places which some other hacking revealed.
Attachments
Patch (7.09 KB, patch)
2013-11-18 14:56 PST, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-11-18 14:56:46 PST
Created attachment 217239 [details] Patch
Mark Hahnenberg
Comment 2 2013-11-18 15:04:55 PST
Committed r159459: <http://trac.webkit.org/changeset/159459>
WebKit Commit Bot
Comment 3 2013-11-19 16:25:23 PST
Re-opened since this is blocked by bug 124616
Mark Hahnenberg
Comment 4 2014-04-29 15:27:25 PDT
APIEntryShim was replaced with JSLockHolder, which has since been put in most of the places APIEntryShim was missing.
Note You need to log in before you can comment on or make changes to this bug.