Bug 124528

Summary: Add PageLoadState class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, mitz, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+, eflews.bot: commit-queue-

Anders Carlsson
Reported 2013-11-18 11:25:27 PST
Add PageLoadState class
Attachments
Patch (11.26 KB, patch)
2013-11-18 11:27 PST, Anders Carlsson 		mitz: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-11-18 11:27:01 PST
Created attachment 217215 [details] Patch
mitz
Comment 2 2013-11-18 11:30:28 PST
Comment on attachment 217215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review Looks OK. > Source/WebKit2/ChangeLog:10 > + Trying to use the main frame load state as the page load state was a bad idea, > + add a new PageLoadState and use it instead. Ultimately the long term plan is to > + transition away from FrameLoadState entirely. FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction? > Source/WebKit2/UIProcess/PageLoadState.h:41 > +private: > + Please remove this.
EFL EWS Bot
Comment 3 2013-11-18 11:37:48 PST
Comment on attachment 217215 [details] Patch Attachment 217215 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/25928075
Anders Carlsson
Comment 4 2013-11-18 11:54:23 PST
(In reply to comment #2) > (From update of attachment 217215 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review > > Looks OK. > > > Source/WebKit2/ChangeLog:10 > > + Trying to use the main frame load state as the page load state was a bad idea, > > + add a new PageLoadState and use it instead. Ultimately the long term plan is to > > + transition away from FrameLoadState entirely. > > FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction? I still think it’s worth abstracting the frame load state out into a separate object.
Anders Carlsson
Comment 5 2013-11-18 11:58:07 PST
Committed r159444: <http://trac.webkit.org/changeset/159444>
Note You need to log in before you can comment on or make changes to this bug.