Bug 124520

Summary: ARM64: Update getHostCallReturnValue() to use architected frame pointer register
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2013-11-18 10:27:49 PST
The ARM64 changes for getHostCallReturnValue() as part of https://bugs.webkit.org/show_bug.cgi?id=123956 - "Change CallFrameRegister to architected frame pointer register" were not done.
Attachments
Patch (1.42 KB, patch)
2013-11-18 10:35 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-18 10:35:35 PST
Created attachment 217208 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-18 10:37:51 PST
Attachment 217208 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITOperations.cpp']" exit_code: 1 Source/JavaScriptCore/jit/JITOperations.cpp:1770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 3 2013-11-18 16:05:41 PST
Committed r159466: <http://trac.webkit.org/changeset/159466>
Michael Saboff
Comment 4 2013-11-18 16:06:48 PST
Comment on attachment 217208 [details] Patch Reviewed in person.
Note You need to log in before you can comment on or make changes to this bug.