Bug 124463

Summary: Move execution of IDBCursorBackendOperations to the IDBServerConnection
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 thorton: review+

Brady Eidson
Reported 2013-11-16 16:01:31 PST
Move execution of IDBCursorBackendOperations to the IDBServerConnection This almost entirely removes knowledge of the backing store from the front end.
Attachments
Patch v1 (65.85 KB, patch)
2013-11-16 16:04 PST, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-11-16 16:04:03 PST
Created attachment 217139 [details] Patch v1
Tim Horton
Comment 2 2013-11-18 11:52:57 PST
Comment on attachment 217139 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=217139&action=review I was once (recently) made to typedef my IDs :( > Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:75 > + void clearCursorData(); given the class name, I wonder if the CursorData suffix is necessary here (and maybe elsewhere) > Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:87 > + int64_t m_cursorID; // Must be destroyed before m_transaction. > + int64_t m_savedCursorID; // Must be destroyed before m_transaction. Destroying int64_ts?
Brady Eidson
Comment 3 2013-11-18 11:59:20 PST
http://trac.webkit.org/changeset/159445
Note You need to log in before you can comment on or make changes to this bug.