Bug 124455

Summary: [sh4] Build is broken since r159346
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, msaboff, oliver, yannick.poirier
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Handle load and store operations with pr register in sh4 LLINT. none

Julien Brianceau
Reported 2013-11-16 09:08:30 PST
r159346 introduced the following instruciton in LowLevelInterpreter32_64.asm storep previousPC, 4[newCallFrame] which is translated into the following invalid assembly for sh4: mov.l pr, @(4, r5)
Attachments
Handle load and store operations with pr register in sh4 LLINT. (2.82 KB, patch)
2013-11-16 09:24 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-16 09:24:45 PST
Created attachment 217126 [details] Handle load and store operations with pr register in sh4 LLINT. This patch fixes the build. The above code is now generated using a temp register: sts pr, r13 mov.l r13, @(4, r5)
WebKit Commit Bot
Comment 2 2013-11-16 14:26:11 PST
Comment on attachment 217126 [details] Handle load and store operations with pr register in sh4 LLINT. Clearing flags on attachment: 217126 Committed r159381: <http://trac.webkit.org/changeset/159381>
WebKit Commit Bot
Comment 3 2013-11-16 14:26:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.