Bug 124455

Summary: [sh4] Build is broken since r159346
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, msaboff, oliver, yannick.poirier
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Handle load and store operations with pr register in sh4 LLINT. none

Description Julien Brianceau 2013-11-16 09:08:30 PST 
r159346 introduced the following instruciton in LowLevelInterpreter32_64.asm

    storep previousPC, 4[newCallFrame] 

which is translated into the following invalid assembly for sh4:

    mov.l pr, @(4, r5)
Comment 1 Julien Brianceau 2013-11-16 09:24:45 PST 
Created attachment 217126 [details]
Handle load and store operations with pr register in sh4 LLINT.

This patch fixes the build. The above code is now generated using a temp register:

    sts pr, r13
    mov.l r13, @(4, r5)
Comment 2 WebKit Commit Bot 2013-11-16 14:26:11 PST 
Comment on attachment 217126 [details]
Handle load and store operations with pr register in sh4 LLINT.

Clearing flags on attachment: 217126

Committed r159381: <http://trac.webkit.org/changeset/159381>
Comment 3 WebKit Commit Bot 2013-11-16 14:26:13 PST 
All reviewed patches have been landed.  Closing bug.