| Summary: | Move IDBCursorBackend operations into their own files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, commit-queue, gyuyoung.kim, jsbell, rakuco | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2013-11-15 17:00:02 PST
Created attachment 217104 [details]
Patch v1
Style bot will complain about IDBCursorBackendOperations.h and IDBCursorBackendOperations.cpp not having newlines at the end. Fixed locally. Attachment 217104 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.h', u'Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.h:102: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:131: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Source/WebCore/CMakeLists.txt:792: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 217104 [details] did not pass style-queue: > Source/WebCore/CMakeLists.txt:792: Line contains tab character. [whitespace/tab] [5] Fixed that, too. Comment on attachment 217104 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=217104&action=review > Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. Please use the license header from the original file. |