Bug 124429

Summary: Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate sidebar and content views
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2013-11-15 12:25:53 PST
The TreeOutlineDataGridSynchronizer will help manage a TreeOutline in the sidebar and DataGrid in the content view.
Attachments
Patch (26.99 KB, patch)
2013-11-15 12:37 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-11-15 12:26:39 PST
<rdar://problem/15483047>
Timothy Hatcher
Comment 2 2013-11-15 12:37:17 PST
Created attachment 217070 [details] Patch
Joseph Pecoraro
Comment 3 2013-11-18 10:23:11 PST
Comment on attachment 217070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217070&action=review r=me > Source/WebInspectorUI/UserInterface/TreeOutlineDataGridSynchronizer.js:60 > + treeOutline.onremove = function(element) { > + this._treeElementRemoved(element); > + if (existingOnRemove) > + existingOnRemove.call(treeOutline, element); > + }.bind(this); Based on the naming for all of these, I would expect the "this.method" to be called after the existing TreeOutline method. But no strong reason to change now.
Timothy Hatcher
Comment 4 2014-01-20 19:01:47 PST
https://trac.webkit.org/changeset/162405
Note You need to log in before you can comment on or make changes to this bug.