Bug 124429

Summary:

Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate sidebar and content views

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-

Description Timothy Hatcher 2013-11-15 12:25:53 PST

The TreeOutlineDataGridSynchronizer will help manage a TreeOutline in the sidebar and DataGrid in the content view.

Comment 1 Radar WebKit Bug Importer 2013-11-15 12:26:39 PST

<rdar://problem/15483047>

Comment 2 Timothy Hatcher 2013-11-15 12:37:17 PST

Created attachment 217070 [details]
Patch

Comment 3 Joseph Pecoraro 2013-11-18 10:23:11 PST

Comment on attachment 217070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217070&action=review

r=me

> Source/WebInspectorUI/UserInterface/TreeOutlineDataGridSynchronizer.js:60
> +    treeOutline.onremove = function(element) {
> +        this._treeElementRemoved(element);
> +        if (existingOnRemove)
> +            existingOnRemove.call(treeOutline, element);
> +    }.bind(this);

Based on the naming for all of these, I would expect the "this.method" to be called after the existing TreeOutline method. But no strong reason to change now.

Comment 4 Timothy Hatcher 2014-01-20 19:01:47 PST

https://trac.webkit.org/changeset/162405