Summary: | [CSS Shapes] Layout using [<box> || <shape>] value | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bear Travis <betravis> | ||||||||||||||
Component: | CSS | Assignee: | Bear Travis <betravis> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, rniwa, syoichi | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 124426 | ||||||||||||||||
Bug Blocks: | 124173 | ||||||||||||||||
Attachments: |
|
Description
Bear Travis
2013-11-15 12:00:34 PST
Created attachment 217491 [details]
Initial Patch
Comment on attachment 217491 [details] Initial Patch Attachment 217491 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/30628019 New failing tests: inspector-protocol/model/highlight-shape-outside.html Created attachment 217500 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 217505 [details]
Fixing inspector test
Created attachment 217585 [details]
Updated patch
Comment on attachment 217585 [details]
Updated patch
r=me
Comment on attachment 217585 [details] Updated patch Rejecting attachment 217585 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 217585, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e-outside-shape-boxes-002.html patching file LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html patching file LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html patching file LayoutTests/inspector-protocol/model/highlight-shape-outside.html Hunk #1 succeeded at 25 with fuzz 2. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/37208112 Created attachment 217897 [details]
Updating patch
Comment on attachment 217897 [details] Updating patch Rejecting attachment 217897 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 217897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Dave Hyatt found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/37468029 Created attachment 217901 [details]
Fixing reviewer
Comment on attachment 217901 [details] Fixing reviewer Clearing flags on attachment: 217901 Committed r159792: <http://trac.webkit.org/changeset/159792> All reviewed patches have been landed. Closing bug. |