Bug 124390

Summary: Web Inspector: DOM.performSearch should accept a list of context nodes
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Web InspectorAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch V1
timothy: review+
Patch for landing none

Alexandru Chiculita
Reported 2013-11-14 18:19:13 PST
DOM.performSearch is currently searching through all the documents in a frame tree. However, the new inspector needs to search just through the current open document. Add a new parameter that can limit the search just to the current frame.
Attachments
Patch V1 (51.54 KB, patch)
2013-11-14 18:30 PST, Alexandru Chiculita 		timothy: review+
DetailsFormatted DiffDiff
Patch for landing (51.63 KB, patch)
2013-11-15 13:33 PST, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-11-14 18:19:37 PST
<rdar://problem/15476369>
Alexandru Chiculita
Comment 2 2013-11-14 18:30:42 PST
Created attachment 217004 [details] Patch V1
Timothy Hatcher
Comment 3 2013-11-15 10:55:27 PST
Comment on attachment 217004 [details] Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=217004&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:888 > // 2) There is no need to push all search results to the front-end at a time, pushing next / previous result > // is sufficient. You can remove this comment. It is not true anymore.
Alexandru Chiculita
Comment 4 2013-11-15 13:33:28 PST
Created attachment 217076 [details] Patch for landing Thanks!
WebKit Commit Bot
Comment 5 2013-11-15 14:06:01 PST
Comment on attachment 217076 [details] Patch for landing Clearing flags on attachment: 217076 Committed r159357: <http://trac.webkit.org/changeset/159357>
WebKit Commit Bot
Comment 6 2013-11-15 14:06:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.