Summary: | [GTK] Bumping GStreamer version to 1.2.1 for the dependencies | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Xabier Rodríguez Calvar
2013-11-14 08:26:51 PST
Created attachment 216940 [details]
Patch
Bumped version up to 1.2.1, disabled GTK doc generation at the dependencies and flagged possible regression.
Comment on attachment 216940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review > Tools/gtk/jhbuildrc:60 > +autogenargs='--enable-introspection --disable-gtk-doc' that will disable doc build for webkit too, no? > LayoutTests/platform/gtk/TestExpectations:1425 > +webkit.org/b/124360 media/video-canvas-drawing-output.html [ Failure ] ah sorry i thought you'd open a new bug. oh well we can change this later (In reply to comment #2) > (From update of attachment 216940 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review > > > Tools/gtk/jhbuildrc:60 > > +autogenargs='--enable-introspection --disable-gtk-doc' > > that will disable doc build for webkit too, no? I thought it would only apply to the dependencies but it is working for WebKit too. Created attachment 216953 [details]
Patch
Removed the GTK doc stuff, that I will do in another bug when disabling tests too.
Comment on attachment 216953 [details]
Patch
Perhaps better to land this tomorrow so it's easier to keep an eye on the bots
(In reply to comment #5) > (From update of attachment 216953 [details]) > Perhaps better to land this tomorrow so it's easier to keep an eye on the bots Thought about it already. Comment on attachment 216953 [details] Patch Clearing flags on attachment: 216953 Committed r159330: <http://trac.webkit.org/changeset/159330> All reviewed patches have been landed. Closing bug. |