Bug 124359

Summary: Make CLoop easier to build, and make it work
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ggaren: review+
Patch ggaren: review+

Oliver Hunt
Reported 2013-11-14 08:19:48 PST
Make CLoop easier to build, and make it work
Attachments
Patch (23.19 KB, patch)
2013-11-14 08:26 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (26.62 KB, patch)
2013-11-14 16:03 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Patch (26.48 KB, patch)
2013-11-14 16:06 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-11-14 08:26:15 PST
Created attachment 216939 [details] Patch
Geoffrey Garen
Comment 2 2013-11-14 08:30:23 PST
Comment on attachment 216939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216939&action=review r=me Please fix stray comment markers. > Source/JavaScriptCore/jit/JITExceptions.cpp:56 > +// catchRoutine = vm->getCTIStub(throwNotCaught).code().executableAddress(); Maybe you meant an #ifdef here? > Source/WTF/wtf/Platform.h:34 > +//#if defined(ENABLE_LLINT_C_LOOP) && ENABLE_LLINT_C_LOOP Remove comment markers?
Oliver Hunt
Comment 3 2013-11-14 08:31:37 PST
(In reply to comment #2) > (From update of attachment 216939 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216939&action=review > > r=me > > Please fix stray comment markers. > > > Source/JavaScriptCore/jit/JITExceptions.cpp:56 > > +// catchRoutine = vm->getCTIStub(throwNotCaught).code().executableAddress(); > > Maybe you meant an #ifdef here? Yup :-D > > > Source/WTF/wtf/Platform.h:34 > > +//#if defined(ENABLE_LLINT_C_LOOP) && ENABLE_LLINT_C_LOOP > > Remove comment markers? Yup, i'm just seeing what happens to the EWS bots
Oliver Hunt
Comment 4 2013-11-14 16:03:05 PST
Created attachment 216993 [details] Patch
Oliver Hunt
Comment 5 2013-11-14 16:06:20 PST
Created attachment 216994 [details] Patch
Geoffrey Garen
Comment 6 2013-11-14 16:06:50 PST
Comment on attachment 216993 [details] Patch r=me
Oliver Hunt
Comment 7 2013-11-14 16:10:42 PST
Committed r159321: <http://trac.webkit.org/changeset/159321>
Note You need to log in before you can comment on or make changes to this bug.