Summary: | Web Inspector: Popovers may shrink unnecessarily | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
Component: | Web Inspector | Assignee: | Antoine Quint <graouts> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Antoine Quint
2013-11-14 06:56:54 PST
Created attachment 216930 [details]
Patch
Comment on attachment 216930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review > Source/WebInspectorUI/UserInterface/Popover.js:402 > + x += containerFrame.maxX() - (x + width); += does not sound right. Should this just be =? > Source/WebInspectorUI/UserInterface/Popover.js:404 > + y += containerFrame.maxY() - (y + height); Ditto. Comment on attachment 216930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review >> Source/WebInspectorUI/UserInterface/Popover.js:402 >> + x += containerFrame.maxX() - (x + width); > > += does not sound right. Should this just be =? Never mind. It will always be negative. Comment on attachment 216930 [details] Patch Clearing flags on attachment: 216930 Committed r159286: <http://trac.webkit.org/changeset/159286> All reviewed patches have been landed. Closing bug. This caused a regression, see https://bugs.webkit.org/show_bug.cgi?id=125069. |