Bug 124347

Summary: REGRESSION(r159276): Lots of crashes for sh4 arch
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, msaboff, yannick.poirier
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 124344    
Bug Blocks:    
Attachments:
Description Flags
Prevent argument register trampling in cCallX macros of LLINT for sh4. none

Julien Brianceau
Reported 2013-11-14 05:18:20 PST
Lots of crashes appeared for sh4 architecture since http://trac.webkit.org/changeset/159276 The issue is identified and I'll submit a patch soon
Attachments
Prevent argument register trampling in cCallX macros of LLINT for sh4. (6.80 KB, patch)
2013-11-14 07:40 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-14 07:40:51 PST
Created attachment 216933 [details] Prevent argument register trampling in cCallX macros of LLINT for sh4. This patch fixes the crashes. If I have time and if you think it's worth, I could move this "setargs" from SH4_INSTRUCTIONS to RISC_INSTRUCTIONS later, as I think this issue could also occur with ARM & MIPS architectures.
WebKit Commit Bot
Comment 2 2013-11-14 08:50:37 PST
Comment on attachment 216933 [details] Prevent argument register trampling in cCallX macros of LLINT for sh4. Clearing flags on attachment: 216933 Committed r159288: <http://trac.webkit.org/changeset/159288>
WebKit Commit Bot
Comment 3 2013-11-14 08:50:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.