Bug 124338

Summary: FontDescription copies should share families list, not duplicate it.
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, esprehn+autocc, glenn, gyuyoung.kim, jcraig, jdiggs, kling, macpherson, mario, menard, samuel_white
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Andreas Kling
Reported 2013-11-14 01:36:32 PST
Potential savings here. We have a looooot of FontDescription copies thanks to copy-on-write StyleInheritedData.
Attachments
Patch (6.09 KB, patch)
2013-11-14 01:38 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-14 01:38:08 PST
Created attachment 216909 [details] Patch
Antti Koivisto
Comment 2 2013-11-14 01:58:33 PST
Comment on attachment 216909 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216909&action=review > Source/WebCore/platform/graphics/FontDescription.h:235 > +inline bool FontDescription::hasEqualFamilies(const FontDescription& other) const > +{ > + if (m_families.data() == other.m_families.data()) > + return true; > + if (m_families.size() != other.m_families.size()) > + return false; > + for (unsigned i = 0; i < m_families.size(); ++i) { > + if (m_families[i] != other.m_families[i]) > + return false; > + } > + return true; > +} Seems more like this could be operator== or equals in RefCountedArray
Andreas Kling
Comment 3 2013-11-14 02:59:57 PST
Committed r159279: <http://trac.webkit.org/changeset/159279>
Note You need to log in before you can comment on or make changes to this bug.