Summary: | SVG has two transform parsers when it should have one. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-01-26 19:21:19 PST
Created attachment 14840 [details]
First attempt
This patch works in general, not really tested for the animation stuff.
Cheers,
Rob.
Comment on attachment 14840 [details]
First attempt
The assignment here doesn't ned to be on separate lines:
+ SVGTransformable::parseTransformValue(m_type, ptr, ptr + m_from.length(), t);
+ m_fromTransform = t;
You could just pass m_fromTransform (if you're not gonna check the bool return anyway)
Personally I might give required/optional longer names. Like requireParamsForTransformType or even requiredForType or something.
Neither of those are functional issues. I'm perhaps still too asleep give this a careful review. More later.
Created attachment 14873 [details]
slightly improved version of rob's patch, fixing one bug
|