Bug 124280

Summary: REGRESSION(r159180): crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, koivisto, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122679, 124236    
Attachments:
Description Flags
ROLLOUT of r159180
koivisto: commit-queue-
proposed fix none

WebKit Commit Bot
Reported 2013-11-13 07:19:53 PST
http://trac.webkit.org/changeset/159180 broke the build: crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot (Requested by anttik on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r159180 (107.83 KB, patch)
2013-11-13 07:20 PST, WebKit Commit Bot
koivisto: commit-queue-
proposed fix (3.18 KB, patch)
2013-11-13 10:37 PST, Alexey Proskuryakov
no flags
WebKit Commit Bot
Comment 1 2013-11-13 07:20:15 PST
Created attachment 216799 [details] ROLLOUT of r159180 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Antti Koivisto
Comment 2 2013-11-13 07:22:52 PST
Skipping the failing test instead
Antti Koivisto
Comment 4 2013-11-13 07:26:06 PST
repurposing
Antti Koivisto
Comment 5 2013-11-13 07:31:00 PST
Alexey Proskuryakov
Comment 6 2013-11-13 10:37:03 PST
Created attachment 216819 [details] proposed fix
Anders Carlsson
Comment 7 2013-11-13 10:47:32 PST
Comment on attachment 216819 [details] proposed fix I'd use std::array instead of those C style arrays but r+ anyway!
WebKit Commit Bot
Comment 8 2013-11-13 11:17:34 PST
Comment on attachment 216819 [details] proposed fix Clearing flags on attachment: 216819 Committed r159211: <http://trac.webkit.org/changeset/159211>
WebKit Commit Bot
Comment 9 2013-11-13 11:17:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.