Bug 124279

Summary: Factor simple line creation loop to function
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Description Antti Koivisto 2013-11-13 06:54:42 PST
refactor
Comment 1 Antti Koivisto 2013-11-13 07:13:14 PST
Created attachment 216798 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-13 07:15:23 PST
Attachment 216798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp']" exit_code: 1
Source/WebCore/rendering/SimpleLineLayout.cpp:260:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2013-11-13 07:33:58 PST
https://trac.webkit.org/r159194