Bug 124279

Summary: Factor simple line creation loop to function
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-11-13 06:54:42 PST
refactor
Attachments
patch (16.54 KB, patch)
2013-11-13 07:13 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-11-13 07:13:14 PST
Created attachment 216798 [details] patch
WebKit Commit Bot
Comment 2 2013-11-13 07:15:23 PST
Attachment 216798 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp']" exit_code: 1 Source/WebCore/rendering/SimpleLineLayout.cpp:260: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2013-11-13 07:33:58 PST
https://trac.webkit.org/r159194
Note You need to log in before you can comment on or make changes to this bug.