Bug 124258

Summary: API::Object::Type should be a strongly typed enum
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: b.long, commit-queue, eflews.bot, eric.carlson, glenn, gyuyoung.kim, gyuyoung.kim, jer.noble, ossy, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+, eflews.bot: commit-queue-

Description Anders Carlsson 2013-11-12 18:42:33 PST
API::Object::Type should be a strongly typed enum
Comment 1 Anders Carlsson 2013-11-12 18:43:50 PST
Created attachment 216762 [details]
Patch
Comment 2 EFL EWS Bot 2013-11-12 19:45:20 PST
Comment on attachment 216762 [details]
Patch

Attachment 216762 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/22938631
Comment 3 Gyuyoung Kim 2013-11-12 23:54:36 PST
It looks this patch needs to support WK2 classes which used by GTK and EFL WK2 additionally. Please refer to http://trac.webkit.org/changeset/159176.
Comment 4 Anders Carlsson 2013-11-13 08:17:50 PST
Committed r159197: <http://trac.webkit.org/changeset/159197>
Comment 5 Csaba Osztrogon√°c 2013-11-13 09:20:09 PST
(In reply to comment #4)
> Committed r159197: <http://trac.webkit.org/changeset/159197>

I'm working on the fix now, will commit soon.
Comment 6 Brendan Long 2013-11-13 09:35:31 PST
> I'm working on the fix now, will commit soon.

Sorry, I didn't realize someone else was already working on this until after I finished my patch. Can someone review the patch on bug #124289?
Comment 7 Csaba Osztrogon√°c 2013-11-13 09:58:06 PST
fixes landed in
- https://trac.webkit.org/changeset/159204
- https://trac.webkit.org/changeset/159206