Bug 124252

Summary: [Mac] Fix some deprecation warnings
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Mac] Fix some deprecation warnings mrowe: review+

Andy Estes
Reported 2013-11-12 17:26:19 PST
[Mac] Fix some deprecation warnings
Attachments
[Mac] Fix some deprecation warnings (7.69 KB, patch)
2013-11-12 17:32 PST, Andy Estes 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-11-12 17:32:40 PST
Created attachment 216752 [details] [Mac] Fix some deprecation warnings
Mark Rowe (bdash)
Comment 2 2013-11-12 17:52:40 PST
Comment on attachment 216752 [details] [Mac] Fix some deprecation warnings View in context: https://bugs.webkit.org/attachment.cgi?id=216752&action=review > Source/WebCore/platform/mac/HTMLConverter.mm:1536 > + dateComponents.get().timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0]; I think it's conventional to do [dateComponents setTimeZone:…]; rather than calling .get() just to use the property syntax. Similarly for the use of getters below.
Andy Estes
Comment 3 2013-11-12 18:02:22 PST
Committed r159171: <http://trac.webkit.org/changeset/159171>
Andy Estes
Comment 4 2013-11-12 18:17:49 PST
Landed a build fix for Mountain Lion in http://trac.webkit.org/changeset/159172
Note You need to log in before you can comment on or make changes to this bug.