Bug 124237

Summary: Move ValueToString out to its own header file to remove duplication
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated Patch none

Bem Jones-Bey
Reported 2013-11-12 15:22:07 PST
Move ValueToString out to its own header file to remove duplication
Attachments
Patch (16.79 KB, patch)
2013-11-12 15:30 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Updated Patch (16.77 KB, patch)
2013-11-12 15:46 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-11-12 15:30:36 PST
Created attachment 216732 [details] Patch
Alexandru Chiculita
Comment 2 2013-11-12 15:42:27 PST
Comment on attachment 216732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216732&action=review r=me > Source/WebCore/platform/LayoutUnit.h:34 > +#ifndef NDEBUG nit: You don't need the #ifndef here. The file itself already has it. Also, you don't do that in the other headers. > Source/WebCore/platform/LayoutUnit.h:970 > +template <> struct ValueToString<LayoutUnit> { nit: you have different styles for the template<> placement. I think the second one is better. template <> struct ValueToString<LayoutUnit> and template <> struct ValueToString<LayoutUnit>
Bem Jones-Bey
Comment 3 2013-11-12 15:46:58 PST
Created attachment 216735 [details] Updated Patch
WebKit Commit Bot
Comment 4 2013-11-12 16:29:26 PST
Comment on attachment 216735 [details] Updated Patch Clearing flags on attachment: 216735 Committed r159159: <http://trac.webkit.org/changeset/159159>
WebKit Commit Bot
Comment 5 2013-11-12 16:29:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.