Bug 124234
| Summary: | Merging SATURATED_LAYOUT_ARITHMETIC flag into SUBPIXEL_LAYOUT | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jfernandez, mrobinson, simon.fraser, syoichi, zalan, zan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 119273 | ||
| Bug Blocks: | 102387, 109975, 115437, 125071 | ||
Javier Fernandez
The SATURATED_LAYOUT_ARITHMETIC flag is intended to protect against potential arithmetic overflow certain layout and rendering operations once the SUBPIXEL_LAYOUT is enabled. After some discussion in the mailing list, it seems that enabling SATURATED_LAYOUT_ARITHMETIC whenever the SUBPIXEL_LAYOUT flag is enabled is more than recommended.
Since the SATURATED_LAYOUT_ARITHMETIC flag makes no sense without SUBPIXEL_LAYOUT, actually there is an assertion preventing this, it seems that the most sensible action is to merge the SATURATED_LAYOUT_ARITHMETIC logic into the SUBPIXEL_LAYOUT, and eventually removing it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
zalan
fixed by bug 136106