Bug 124230

Summary: Web Inspector: ContentFlowTreeContentView should use only one DOMTreeOutline
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Web InspectorAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch V1
none
Patch V2 none

Alexandru Chiculita
Reported 2013-11-12 13:48:44 PST
Currently ContentFlowTreeContentView creates one DOMTreeOutline for each root element with "-webkit-flow-into". The issue is that DOMTreeOutline objects are disconnected, so navigation across root elements is also broken. Also, ContentFlowTreeContentView tends to reimplement a lot of the DOMTreeContentView, so finding a way to inherit from it would save a lot of duplicated code.
Attachments
Patch V1 (20.83 KB, patch)
2013-11-12 14:14 PST, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
Patch V2 (25.82 KB, patch)
2013-11-12 14:24 PST, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-11-12 13:49:13 PST
<rdar://problem/15452067>
Alexandru Chiculita
Comment 2 2013-11-12 14:14:05 PST
Created attachment 216723 [details] Patch V1
Alexandru Chiculita
Comment 3 2013-11-12 14:24:14 PST
Created attachment 216725 [details] Patch V2 Renamed ContentFlowTreeContentView to ContentFlowDOMTreeContentView to better reflect the inheritance of the object.
WebKit Commit Bot
Comment 4 2013-11-12 15:01:51 PST
Comment on attachment 216725 [details] Patch V2 Clearing flags on attachment: 216725 Committed r159151: <http://trac.webkit.org/changeset/159151>
WebKit Commit Bot
Comment 5 2013-11-12 15:01:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.