Summary: | Modifying RTCSessionDescription object construction to match the spec | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||||
Component: | WebCore Misc. | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, pnormand, rakuco, tommyw | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 124288 | ||||||||||||
Attachments: |
|
Description
Thiago de Barros Lacerda
2013-11-12 10:48:16 PST
Created attachment 216694 [details]
Patch
This patch needs the hash generated by xcode, to put the new added file in xcode project files Created attachment 216803 [details]
Rebased patch
Comment on attachment 216803 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=216803&action=review > Source/WebCore/ChangeLog:13 > + According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional, > + which must not be nullable. > + If the 'type' and/or 'sdp' keys are not present, the string object that stores them in the > + RTCSessionDescription class, must be null in those cases. > + Also, if an object that is not a Dictionary is passed as argument to the constructor, an exception must be > + raised. Nit: I don't think the line breaks after each sentence aid readability. I would remove them. > Source/WebCore/bindings/js/JSRTCSessionDescriptionCustom.cpp:46 > + return throwVMError(exec, createTypeError(exec, "Optional description init argument of RTCSessionDescription must be a valid Dictionary")); Nit: I would change this to "Optional RTCSessionDescription constructor argument must be a valid Dictionary" Created attachment 216829 [details]
Patch
Eric, could you send me the patch to apply in xcode build files? Created attachment 216841 [details]
Patch for landing
Comment on attachment 216841 [details] Patch for landing Clearing flags on attachment: 216841 Committed r159230: <http://trac.webkit.org/changeset/159230> |