Bug 124208

Summary: Begin cleaning up handling of ImmutableArray vectors
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-11-12 09:07:02 PST
Begin cleaning up handling of ImmutableArray vectors
Attachments
Patch (32.22 KB, patch)
2013-11-12 09:08 PST, Anders Carlsson
kling: review+
Anders Carlsson
Comment 1 2013-11-12 09:08:52 PST
Andreas Kling
Comment 2 2013-11-12 09:20:39 PST
Comment on attachment 216683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216683&action=review r=me > Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:122 > + hostnameStrings.append(WebString::create(hostname)); I thought this was supposed to be uncheckedAppend(). Is this intentional? Why aren't you using uncheckedAppend() here?
Anders Carlsson
Comment 3 2013-11-12 09:38:43 PST
Note You need to log in before you can comment on or make changes to this bug.