Bug 124208

Summary:

Begin cleaning up handling of ImmutableArray vectors

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2013-11-12 09:07:02 PST

Begin cleaning up handling of ImmutableArray vectors

Comment 1 Anders Carlsson 2013-11-12 09:08:52 PST

Created attachment 216683 [details]
Patch

Comment 2 Andreas Kling 2013-11-12 09:20:39 PST

Comment on attachment 216683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216683&action=review

r=me

> Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:122
> +        hostnameStrings.append(WebString::create(hostname));

I thought this was supposed to be uncheckedAppend(). Is this intentional? Why aren't you using uncheckedAppend() here?

Comment 3 Anders Carlsson 2013-11-12 09:38:43 PST

Committed r159117: <http://trac.webkit.org/changeset/159117>