Bug 124207

Summary: Make the placed floats tree use LayoutUnit instead of int
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
New Patch none

Bem Jones-Bey
Reported 2013-11-12 08:22:31 PST
Floats use LayoutUnits for all dimensions, it doesn't really make sense to be converting to ints for the placed floats tree.
Attachments
Patch (7.75 KB, patch)
2013-11-12 09:18 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
New Patch (5.66 KB, patch)
2013-11-12 16:32 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-11-12 09:18:15 PST
Created attachment 216685 [details] Patch
Bem Jones-Bey
Comment 2 2013-11-12 16:32:27 PST
Created attachment 216740 [details] New Patch
Alexandru Chiculita
Comment 3 2013-11-12 16:36:23 PST
Comment on attachment 216740 [details] New Patch Looks good, r=me.
Bem Jones-Bey
Comment 4 2013-11-12 16:39:25 PST
Comment on attachment 216740 [details] New Patch Note that there is a small but non-zero chance that this could cause small precision issues with tests when subpixel layout is enabled. I have run all of the tests locally, and have not seen any issues, so I don't expect there to be any new issues from this change.
WebKit Commit Bot
Comment 5 2013-11-12 17:30:28 PST
Comment on attachment 216740 [details] New Patch Clearing flags on attachment: 216740 Committed r159166: <http://trac.webkit.org/changeset/159166>
WebKit Commit Bot
Comment 6 2013-11-12 17:30:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.