Bug 124190

Summary:

Web Inspector: Extract InspectorAgentRegistry from InspectorBaseAgent

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix (Also for bots)	timothy: review+
[PATCH] Updated for Bots	buildbot: commit-queue-
[PATCH] Updated for Bots 2	none

Joseph Pecoraro

Reported 2013-11-11 23:08:21 PST

Move InspectorAgentRegistry into its own .h/.cpp for clarity.

Attachments
[PATCH] Proposed Fix (Also for bots) (26.08 KB, patch) 2013-11-11 23:10 PST, Joseph Pecoraro	timothy: review+	Details Formatted Diff Diff
[PATCH] Updated for Bots (26.04 KB, patch) 2013-11-12 12:52 PST, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
[PATCH] Updated for Bots 2 (26.12 KB, patch) 2013-11-12 13:39 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-11-11 23:08:36 PST

<rdar://problem/15445565>

Joseph Pecoraro

Comment 2 2013-11-11 23:10:08 PST

Created attachment 216639 [details] [PATCH] Proposed Fix (Also for bots)

Joseph Pecoraro

Comment 3 2013-11-12 12:52:09 PST

Created attachment 216707 [details] [PATCH] Updated for Bots

Build Bot

Comment 4 2013-11-12 13:35:31 PST

Comment on attachment 216707 [details] [PATCH] Updated for Bots Attachment 216707 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/22749607

Joseph Pecoraro

Comment 5 2013-11-12 13:39:43 PST

Created attachment 216718 [details] [PATCH] Updated for Bots 2

WebKit Commit Bot

Comment 6 2013-11-12 16:51:54 PST

Comment on attachment 216718 [details] [PATCH] Updated for Bots 2 Clearing flags on attachment: 216718 Committed r159162: <http://trac.webkit.org/changeset/159162>

WebKit Commit Bot

Comment 7 2013-11-12 16:51:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.