Bug 124182

Summary: [WK2][EFL] Build break after r159088
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, cdumez, cmarcelo, commit-queue, gyuyoung.kim, gyuyoung.kim, jinwoo7.song, lucas.de.marchi, luiz, noam, ossy, rakuco, thorton, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124174    
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2013-11-11 20:33:03 PST
Since r159088, urlAtProcessExit() was removed. I think that Efl port just use url as notification so that we'd better to remove this interface.
Attachments
Patch (9.89 KB, patch)
2013-11-11 20:37 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-11-11 20:37:36 PST
Created attachment 216631 [details] Patch
Gyuyoung Kim
Comment 2 2013-11-11 20:52:02 PST
Andersca, could you take a look this ?
Gyuyoung Kim
Comment 3 2013-11-11 22:15:53 PST
Comment on attachment 216631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216631&action=review > Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-87 > - ewk_view_html_string_load(ewkView->evasObject(), "The web process has crashed.", 0, urlString); I think it is helpful to report url which page is crashed. So, I don't know why andersca removed it.
Csaba Osztrogonác
Comment 4 2013-11-11 22:22:01 PST
+1 for reverting the unprofessional r159088 and let platforms report warning.
Gyuyoung Kim
Comment 5 2013-11-11 22:35:56 PST
r159088 is being reverted.
Ryuan Choi
Comment 6 2013-11-11 22:37:23 PST
Comment on attachment 216631 [details] Patch OK, I considered that it's minor if WK2 decide to remove it. Revert is better for me, too. Cleard flags.
Csaba Osztrogonác
Comment 7 2013-11-11 22:40:28 PST
(In reply to comment #4) > +1 for reverting the unprofessional r159088 and let platforms report warning. Sorry for the word "unprofessional", I didn't know if it isn't a political correct word for buggy/bad/wrong/mistake, I didn't want to hurt anybody. :(
Note You need to log in before you can comment on or make changes to this bug.