Bug 124180

Summary:

GStreamer source files should be included in Windows build

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	none
Patch	bfulgham: review+

Alex Christensen

Reported 2013-11-11 20:08:42 PST

I have a working concept of WinCairo with video enabled, and I'd like to get this to a point where it could be easily repeatably built. Step 1 is to include the gstreamer files in the Windows build. Step 2 will be to separate the ENABLE(VIDEO) from the USE(CA), and then we'll include some more code and do some fine polishing.

Attachments
Patch (15.33 KB, patch) 2013-11-11 20:17 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (30.40 KB, patch) 2013-11-12 13:29 PST, Alex Christensen	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-11-11 20:17:30 PST

Created attachment 216630 [details] Patch

Philippe Normand

Comment 2 2013-11-11 23:22:32 PST

Comment on attachment 216630 [details] Patch This looks good to me but I'll let Brent give the final review. Would be nice to have green win EWS too :)

Brent Fulgham

Comment 3 2013-11-12 13:20:08 PST

Comment on attachment 216630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216630&action=review This seems fine, but please exclude them from the Apple port build to reduce confusion. > Source/WTF/WTF.vcxproj/WTF.vcxproj:78 > + <ClCompile Include="..\wtf\gobject\GRefPtr.cpp" /> These need to be marked as "don't build" on non-WinCairo ports. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7261 > + <ClCompile Include="..\platform\graphics\gstreamer\WebKitWebSourceGStreamer.cpp" /> These should be excluded as well. I know that they don't compile due to the USE(GSTREAMER) guards, but it might confuse someone who thinks GStreamer is being used under the Apple port.

Alex Christensen

Comment 4 2013-11-12 13:29:41 PST

Created attachment 216713 [details] Patch

Brent Fulgham

Comment 5 2013-11-12 13:37:53 PST

Comment on attachment 216713 [details] Patch r=me

Alex Christensen

Comment 6 2013-11-12 13:43:39 PST

http://trac.webkit.org/changeset/159146

Note You need to log in before you can comment on or make changes to this bug.