Bug 124180

Summary: GStreamer source files should be included in Windows build
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Description Alex Christensen 2013-11-11 20:08:42 PST
I have a working concept of WinCairo with video enabled, and I'd like to get this to a point where it could be easily repeatably built.  Step 1 is to include the gstreamer files in the Windows build.  Step 2 will be to separate the ENABLE(VIDEO) from the USE(CA), and then we'll include some more code and do some fine polishing.
Comment 1 Alex Christensen 2013-11-11 20:17:30 PST
Created attachment 216630 [details]
Patch
Comment 2 Philippe Normand 2013-11-11 23:22:32 PST
Comment on attachment 216630 [details]
Patch

This looks good to me but I'll let Brent give the final review. Would be nice to have green win EWS too :)
Comment 3 Brent Fulgham 2013-11-12 13:20:08 PST
Comment on attachment 216630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216630&action=review

This seems fine, but please exclude them from the Apple port build to reduce confusion.

> Source/WTF/WTF.vcxproj/WTF.vcxproj:78
> +    <ClCompile Include="..\wtf\gobject\GRefPtr.cpp" />

These need to be marked as "don't build" on non-WinCairo ports.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7261
> +    <ClCompile Include="..\platform\graphics\gstreamer\WebKitWebSourceGStreamer.cpp" />

These should be excluded as well.  I know that they don't compile due to the USE(GSTREAMER) guards, but it might confuse someone who thinks GStreamer is being used under the Apple port.
Comment 4 Alex Christensen 2013-11-12 13:29:41 PST
Created attachment 216713 [details]
Patch
Comment 5 Brent Fulgham 2013-11-12 13:37:53 PST
Comment on attachment 216713 [details]
Patch

r=me
Comment 6 Alex Christensen 2013-11-12 13:43:39 PST
http://trac.webkit.org/changeset/159146