Bug 124179

Summary: Web Inspector: Remove some unused generated code
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-11-11 19:49:28 PST
• InspectorBackendDispatcher::getCommandName is not used. • InspectorFrontend::Foo classes never modify their InspectorFrontendChannel, so the getter/setter and null checks are unnecessary. Make m_inspectorFrontendChannel protected to avoid unused warning. This base class will go away. This is just some prep for generating separate InspectorBackendDispatchers / InspectorFrontendDispatchers per domain. Start by removing some of the dead code not being converted / carried over.
Attachments
[PATCH] Proposed Fix (3.32 KB, patch)
2013-11-11 19:51 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-11-11 19:49:52 PST
<rdar://problem/15444748>
Joseph Pecoraro
Comment 2 2013-11-11 19:51:18 PST
Created attachment 216629 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2013-11-11 20:37:52 PST
Comment on attachment 216629 [details] [PATCH] Proposed Fix Clearing flags on attachment: 216629 Committed r159093: <http://trac.webkit.org/changeset/159093>
WebKit Commit Bot
Comment 4 2013-11-11 20:37:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.