Summary: | Start moving off of NSCalendarDate | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ricky Mondello <rmondello> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aestes, buildbot, commit-queue, conrad_shultz, rmondello, rniwa | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Ricky Mondello
2013-11-11 17:42:33 PST
Created attachment 216627 [details]
First attempt to run through EWS.
Comment on attachment 216627 [details] First attempt to run through EWS. Attachment 216627 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22589461 Created attachment 216628 [details]
Another attempt; might work for 10.8
Comment on attachment 216627 [details] First attempt to run through EWS. Attachment 216627 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22369517 Mark pointed out that my patch breaks the API contract (going as far as to explicitly edit a comment explaining it) of -[WebHistory orderedItemsLastVisitedOnDay:] and is therefore unacceptable. Specifically, `orderedItemsLastVisitedOnDay:` now takes an NSDate instead of an NSCalendarDate. Created attachment 216641 [details]
This time, don’t modify API.
I'm not a reviewer, but the date math and API usage look correct to me. Comment on attachment 216641 [details] This time, don’t modify API. View in context: https://bugs.webkit.org/attachment.cgi?id=216641&action=review > Source/WebKit/mac/History/WebHistory.h:131 > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" > - (NSArray *)orderedItemsLastVisitedOnDay:(NSCalendarDate *)calendarDate; > +#pragma clang diagnostic pop We can't disable deprecation warnings in public headers! Created attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API
Comment on attachment 216705 [details] Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API Attachment 216705 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22888797 Comment on attachment 216705 [details] Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API Attachment 216705 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22369739 Comment on attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API
NSCalendarDate was also deprecated in iOS 7. Instead of using NS_DEPRECATED_MAC(10_4, 10_9), you should use NS_DEPRECATED(10_4, 10_9, 2_0, 7_0).
Created attachment 217267 [details] Disable the deprecation warnings This change in WebHistory.h isn't ideal, but I'm really bored with having to work around this. We can remove it when we address bug 124189. Attachment 217267 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistory.mm']" exit_code: 1
Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 217267 [details] Disable the deprecation warnings Clearing flags on attachment: 217267 Committed r159480: <http://trac.webkit.org/changeset/159480> All reviewed patches have been landed. Closing bug. |