Bug 124176

Summary: FrameFilter can just be an std::function instead
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Anders Carlsson 2013-11-11 17:37:48 PST
FrameFilter can just be an std::function instead
Comment 1 Anders Carlsson 2013-11-11 17:39:15 PST
Created attachment 216626 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-11 17:40:02 PST
Attachment 216626 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp']" exit_code: 1
Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:425:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/loader/archive/cf/LegacyWebArchive.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/loader/archive/cf/LegacyWebArchive.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-11-11 17:49:36 PST
Committed r159089: <http://trac.webkit.org/changeset/159089>